Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add command line option --version #4126

Merged
merged 1 commit into from
Oct 8, 2020
Merged

Add command line option --version #4126

merged 1 commit into from
Oct 8, 2020

Conversation

fingolfin
Copy link
Member

Resolves #3735

I guess we could try to add a test, but I am not quite sure what to test for... Perhaps a non-zero exit code, and then match the output against a regex?

@fingolfin fingolfin added the release notes: to be added PRs introducing changes that should be (but have not yet been) mentioned in the release notes label Oct 7, 2020
@coveralls
Copy link

Coverage Status

Coverage increased (+0.007%) to 93.735% when pulling 3c7b9c8 on fingolfin:mh/version into 7b98f48 on gap-system:master.

wilfwilson
wilfwilson approved these changes Oct 7, 2020
View reviewed changes
Copy link
Member

@wilfwilson wilfwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How would you even go about adding a test? Would it have to go in etc/ci.sh somehow? Anyway, if you feel like doing it, it would be nice to have, but I'm satisfied without a test.

@fingolfin
Copy link
Member Author

Yeah, in etc/ci.sh -- indeed, not very much to test, though one could test that the exit code is as desired, and that the output consist of a single line matching a certain pattern (as opposed to an error message or so). But I am not sure how useful that'd really be... so unless somebody reaaaallly wants it, I'd rather not invest the effort :-)

@ChrisJefferson ChrisJefferson merged commit 22b45ea into gap-system:master Oct 8, 2020
@fingolfin fingolfin deleted the mh/version branch October 8, 2020 21:15
@ThomasBreuer ThomasBreuer self-assigned this Feb 16, 2021
@ThomasBreuer ThomasBreuer changed the title Add 'gap --version' Added a command line option --version. Feb 16, 2021
@ThomasBreuer ThomasBreuer added release notes: added PRs introducing changes that have since been mentioned in the release notes and removed release notes: to be added PRs introducing changes that should be (but have not yet been) mentioned in the release notes labels Feb 16, 2021
@ThomasBreuer ThomasBreuer removed their assignment Feb 16, 2021
@olexandr-konovalov olexandr-konovalov mentioned this pull request Mar 23, 2021
Merged
@fingolfin fingolfin changed the title Added a command line option --version. Add command line option --version Aug 17, 2022
@fingolfin fingolfin added kind: enhancement Label for issues suggesting enhancements; and for pull requests implementing enhancements release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes kind: new feature and removed release notes: added PRs introducing changes that have since been mentioned in the release notes labels Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wilfwilson wilfwilson wilfwilson approved these changes

@wucas wucas Awaiting requested review from wucas

Assignees
No one assigned
Labels
kind: enhancement Label for issues suggesting enhancements; and for pull requests implementing enhancements kind: new feature release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add --version command line option
5 participants
@fingolfin @coveralls @wilfwilson @ChrisJefferson @ThomasBreuer